Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chained controllers example #162

Conversation

destogl
Copy link
Member

@destogl destogl commented Mar 24, 2022

To test the example, checkout the following branches and following dependencies:

ros-controls/ros2_control#667
ros-controls/ros2_controllers#318

Then, follow the instructions in README added in this PR.

@destogl destogl added the New example This PR is proposing a new example. label Mar 24, 2022
@destogl destogl self-assigned this Mar 24, 2022
@destogl destogl requested a review from bijoua29 March 24, 2022 19:33
@destogl destogl force-pushed the chained-controllers-example branch from 3c6eb16 to 056b06b Compare March 29, 2022 17:53
Copy link
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good demo with multiple levels to showcase chainable controllers.

@destogl destogl requested a review from livanov93 April 26, 2022 20:23
livanov93
livanov93 previously approved these changes May 3, 2022
Copy link
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All instructions were executed and the results were as expected.
Nice work once again!

@christophfroehlich
Copy link
Contributor

How can this be integrated? Can we merge ros-controls/ros2_controllers#318 into master or create an example without the need for custom ros2_controllers?

The status of ros-controls/ros2_controllers#318 is currently broken (no tf messages, and there is a merge conflict with master which I did not investigate this further)

@destogl
Copy link
Member Author

destogl commented Mar 16, 2023

No idea, we will probably have to kill this PR and get some better examples when more controllers get chainable options

@olivier-stasse
Copy link
Collaborator

@christophfroehlich Maybe this PR can be closed as we already have it in example_12 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New example This PR is proposing a new example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants