Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touchup Dockerfile and create a workflow building it #323

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Touchup Dockerfile and create a workflow building it #323

merged 1 commit into from
Jun 29, 2023

Conversation

christophfroehlich
Copy link
Contributor

  • Apply some good practice for docker files (cleanups)
  • Fix rosdep --skip-keys
  • Create workflows to regularly build the docker image
  • Remove remnant of Gazebo - PR

@christophfroehlich
Copy link
Contributor Author

Maybe limiting the docker workflow to changes of the dockerfile would be sufficient, too.

@ARK3r
Copy link
Contributor

ARK3r commented Jun 28, 2023 •
edited
Loading

With a bunch of other dependencies, I think having a daily build would be good.

Or maybe that's not exactly the responsibility of this dockerfile build to find out errors

olivier-stasse
olivier-stasse approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit dbb7c65 into ros-controls:master Jun 29, 2023
@christophfroehlich christophfroehlich deleted the docker_touchup branch June 29, 2023 12:18
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 29, 2023
@christophfroehlich @mergify
Touchup Dockerfile and create a workflow building it (#323)
1089ffc 
(cherry picked from commit dbb7c65)

# Conflicts:
#	.github/workflows/rolling-binary-build.yml
@mergify mergify bot mentioned this pull request Jun 29, 2023
Merged
christophfroehlich added a commit that referenced this pull request Jun 29, 2023
@mergify @christophfroehlich
Touchup Dockerfile and create a workflow building it (backport #323) (#…
ae0a7d3 
…324)


Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivier-stasse olivier-stasse olivier-stasse approved these changes

@ARK3r ARK3r Awaiting requested review from ARK3r

@aprotyas aprotyas Awaiting requested review from aprotyas

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@bmagyar bmagyar Awaiting requested review from bmagyar

@duringhof duringhof Awaiting requested review from duringhof

@jaron-l jaron-l Awaiting requested review from jaron-l

@qiayuanl qiayuanl Awaiting requested review from qiayuanl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @ARK3r @olivier-stasse