-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker instructions #351
Update docker instructions #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested.
This a nice addition.
I had to battle a little bit to understand how to build the documentation in a stand-alone mode. I will try to propose a PR on control.ros.org.
The way it was tested was to modify the script make_help_scripts/deploy_defines
specifying the repo and the branch
what was the problem with spinhx? I always clone the three subrepos manually or create symlinks into the folder. |
I simply changed
to
in no need to clone locally the subrepos as it is done by the script. I failed to do it by hand... |
Otherwise for this PR, if you fix the conflict file we can merge it. |
Previous commit was making the format test failed and was at the wrong place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - All tests are passing
@christophfroehlich sorry I fixed some minor issues and did this by commiting directy on your branch. Hope this is fine. |
@Mergifyio backport humble |
✅ Backports have been created
|
* Update docker instructions * Update userdoc.rst --------- Co-authored-by: Olivier Stasse <ostasse@laas.fr> (cherry picked from commit 07a897f)
Using the sphinx tabs plugin, we could improve the instructions using the docker container.
Choosing one tab switches all group-tabs at once (as known from docs.ros.org). What do you think? Did that only for example 1, but would apply the changes to the others, too.