Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URDF: Add limits to the continuous joints #387

Merged
merged 1 commit into from
Dec 24, 2023
Merged

URDF: Add limits to the continuous joints #387

merged 1 commit into from
Dec 24, 2023

Conversation

christophfroehlich
Copy link
Contributor

While testing rqt_joint_trajectory_controller we realized that the URDFs lack limits for the continuous joints (velocity + effort).

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023 •
edited
Loading

backport humble

✅ Backports have been created

saikishor
saikishor approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich mentioned this pull request Dec 7, 2023
Merged
@christophfroehlich christophfroehlich mentioned this pull request Dec 11, 2023
Closed
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport iron

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 24, 2023 •
edited
Loading

backport iron

✅ Backports have been created

@christophfroehlich christophfroehlich merged commit d0db83f into ros-controls:master Dec 24, 2023
12 checks passed
@christophfroehlich christophfroehlich deleted the add_limits branch December 24, 2023 14:48
mergify bot pushed a commit that referenced this pull request Dec 24, 2023
@christophfroehlich @mergify
Add limits to the continuous joints (#387)
e3cf685 
(cherry picked from commit d0db83f)
mergify bot pushed a commit that referenced this pull request Dec 24, 2023
@christophfroehlich @mergify
Add limits to the continuous joints (#387)
a2f1fca 
(cherry picked from commit d0db83f)
This was referenced Dec 24, 2023
Merged
Merged
saikishor pushed a commit that referenced this pull request Dec 24, 2023
@mergify @christophfroehlich
Add limits to the continuous joints (#387) (#412)
c4c283a 
(cherry picked from commit d0db83f)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
saikishor pushed a commit that referenced this pull request Dec 24, 2023
@mergify @christophfroehlich
Add limits to the continuous joints (#387) (#411)
2a7fbea 
(cherry picked from commit d0db83f)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
olivier-stasse
olivier-stasse reviewed Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivier-stasse olivier-stasse olivier-stasse left review comments

@destogl destogl Awaiting requested review from destogl

@bmagyar bmagyar Awaiting requested review from bmagyar

@saikishor saikishor Awaiting requested review from saikishor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @olivier-stasse @saikishor