Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change interface export variant #396

Conversation

mamueluth
Copy link
Member

This showcases for example 1 how the changes proposed in this PR would affect the hardware. The adjusted example has been tested and works with the changes. If you want to test them, first checkout the branch from the before mentioned PR.

The changes are described in more detail in the PR:

  • Storage for Command-/StateInterface is moved to the SystemInterface -> no local vectors of commads/states in the hardware (memory for Command-/StateInterfaces)
  • The exportation of the Command-/StateInterfaces has been removed and is handled by the Framework -> removed export_state_interfaces() and export_command_interfaces() in the HW
  • SystemInterface provides set_state/get_state and set_commad/get_command methods to update states/read commands in the HW. Can either be used by passing the InterfaceDescription or state_interface-/command_interface-name

If you want to test:

  1. Checkout the change_interface_export_variant branch from this PR
  2. Follow the instructions here to run the demo.

ros2 launch ros2_control_demo_example_1 rrbot.launch.py
ros2 launch ros2_control_demo_example_1 test_forward_position_controller.launch.py

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! @mamueluth could you merge master into your fork pls?

@christophfroehlich
Copy link
Contributor

Rolling semi-binary and binary testing fail because of an issue while installing ros-rolling-gz-sim, binary main builds fail until the next sync.

@christophfroehlich christophfroehlich merged commit 747a481 into ros-controls:master Oct 8, 2024
9 of 13 checks passed
@destogl destogl deleted the change_interface_export_variant branch October 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants