-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change interface export variant #396
Merged
christophfroehlich
merged 6 commits into
ros-controls:master
from
StoglRobotics-forks:change_interface_export_variant
Oct 8, 2024
Merged
Change interface export variant #396
christophfroehlich
merged 6 commits into
ros-controls:master
from
StoglRobotics-forks:change_interface_export_variant
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
christophfroehlich,
destogl,
duringhof,
mcbed,
saikishor and
VanshGehlot
December 20, 2023 14:38
mamueluth
force-pushed
the
change_interface_export_variant
branch
from
May 22, 2024 11:47
4823232
to
d982069
Compare
mamueluth
force-pushed
the
change_interface_export_variant
branch
from
August 14, 2024 08:56
d982069
to
e1ebe6b
Compare
1 task
christophfroehlich
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good! @mamueluth could you merge master into your fork pls?
destogl
approved these changes
Oct 8, 2024
Rolling semi-binary and binary testing fail because of an issue while installing ros-rolling-gz-sim, binary main builds fail until the next sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showcases for example 1 how the changes proposed in this PR would affect the hardware. The adjusted example has been tested and works with the changes. If you want to test them, first checkout the branch from the before mentioned PR.
The changes are described in more detail in the PR:
export_state_interfaces()
andexport_command_interfaces()
in the HWset_state
/get_state
andset_commad
/get_command
methods to update states/read commands in the HW. Can either be used by passing theInterfaceDescription
orstate_interface-
/command_interface-name
If you want to test:
change_interface_export_variant
branch from this PR