Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Use a single list for lint job #451

Merged
merged 3 commits into from
Feb 18, 2024
Merged

[CI] Use a single list for lint job #451

merged 3 commits into from
Feb 18, 2024

Conversation

christophfroehlich
Copy link
Contributor

Just simpler to maintain.

@christophfroehlich
Copy link
Contributor Author

👀 @ARK3r I fixed the cpplint error

/workspaces/ros2_rolling_ws/src/ros2_control_demos/example_11/hardware/include/ros2_control_demo_example_11/carlikebot_system.hpp:48:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [5]

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble iron

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2024 •
edited
Loading

backport humble iron

✅ Backports have been created

bmagyar
bmagyar approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@bmagyar bmagyar merged commit 044db05 into ros-controls:master Feb 18, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Feb 18, 2024
@christophfroehlich @mergify
[CI] Use a single list for lint job (#451)
60bbd55 
* Use a single list for lint job

* Add explicit keyword

* Update broken links

(cherry picked from commit 044db05)

# Conflicts:
#	.github/workflows/ci-ros-lint.yml
@mergify mergify bot mentioned this pull request Feb 18, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 18, 2024
@christophfroehlich @mergify
[CI] Use a single list for lint job (#451)
fa4703b 
* Use a single list for lint job

* Add explicit keyword

* Update broken links

(cherry picked from commit 044db05)
@mergify mergify bot mentioned this pull request Feb 18, 2024
Merged
christophfroehlich added a commit that referenced this pull request Feb 18, 2024
@mergify @christophfroehlich
[CI] Use a single list for lint job (#451) (#454)
d9ed00e 
* Use a single list for lint job

* Add explicit keyword

* Update broken links

(cherry picked from commit 044db05)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Feb 18, 2024
@mergify @christophfroehlich
[CI] Use a single list for lint job (backport #451) (#453)
4543658 
* [CI] Use a single list for lint job (#451)

* Use a single list for lint job

* Add explicit keyword

* Update broken links

(cherry picked from commit 044db05)

# Conflicts:
#	.github/workflows/ci-ros-lint.yml

* Fix merge conflict

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
@christophfroehlich christophfroehlich deleted the ci_ros_lint branch March 27, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@mcbed mcbed Awaiting requested review from mcbed

@moriarty moriarty Awaiting requested review from moriarty

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @bmagyar