Update all demos using the description from topic rather than the parameter (backport #456) #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
erickisos,
fmauch,
jaron-l and
peterdavidfagan
…ameter (#456) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
christophfroehlich
force-pushed
the
use_robot_description_topic
branch
from
08b501d
to
ceffe4f
Compare
fmauch
approved these changes
Mar 13, 2024
|
Thanks @christophfroehlich for the effort! |
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…ameter (#456) (#472) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 11d699b)
christophfroehlich
added a commit
that referenced
this pull request
Mar 13, 2024
…ameter (#456) (#472) (#473) * Use correct remapping for iron/humble * Updated demos * Example 14: Check for NaN in write method Since activation of the "hardware" takes some time, the resource manager might try to write the initial NaN value to the hardware. This commit adds a check to the write method for that. --------- Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 11d699b) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual backport of #456 + necessary remapping of the robot_description topic.