[example_9] Switch to gz_ros2_control #482
Conversation
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
jaron-l,
peterdavidfagan and
VX792
christophfroehlich
changed the title
christophfroehlich
force-pushed
the
switch_gazebo_classic_gazebo
branch
from
89407b1
to
62190cb
Compare
There was a problem hiding this comment.
Dear @destogl and @christophfroehlich thanks a lot for both contributions. Switching to gz-sim is definitely a plus.
But keeping the examples simple and documented are the main target of the repo I guess.
So my preference would go for this one.
But maybe there are some points I missed.
example_9/package.xml
Outdated
| <exec_depend>gazebo_ros2_control</exec_depend> | ||
| <exec_depend condition="$GZ_VERSION == ''">ros_gz_sim</exec_depend> | ||
| <exec_depend condition="$GZ_VERSION == 'harmonic'">ros_gz_sim</exec_depend> | ||
| <exec_depend condition="$GZ_VERSION == 'garden'">ros_gz_sim</exec_depend> |
There was a problem hiding this comment.
Naive question: why do we need to test GZ_VERSION if this is always ros_gz_sim ?
Or is just to test that GZ_VERSION is set ?
I do not see it in https://gazebosim.org/docs/harmonic/migrating_gazebo_classic_ros2_packages
There was a problem hiding this comment.
I just copied it over from gz_ros2_control and deleted the fortress branch because I don't want to backport this to humble. Now it doesn't make sense, that's right. fixed with bcdfedc
christophfroehlich
dismissed stale reviews from olivier-stasse and destogl
via
bcdfedc
Co-authored-by: Dr. Denis <denis@stogl.de>
christophfroehlich
force-pushed
the
switch_gazebo_classic_gazebo
branch
from
bcdfedc
to
1d1cf31
Compare
gazebo classic won't be available for Ubuntu noble, and as a consequence gazebo_ros2_control won't be released for rolling any more. Let's switch to gazebo on the rolling branch of the demos, and use it from Jazzy onwards.