Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change links to be sphinx refs #518

Merged
merged 1 commit into from
May 14, 2024
Merged

Change links to be sphinx refs #518

merged 1 commit into from
May 14, 2024

Conversation

christophfroehlich
Copy link
Contributor

Using sphinx references seems to be more robust. (linkcheck failed today while releasing the Jazzy version).

aprotyas
aprotyas approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@aprotyas aprotyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense as long as the Sphinx project structure is unchanged.

@christophfroehlich
Copy link
Contributor Author

This makes sense as long as the Sphinx project structure is unchanged.

yes, but then would the absolute paths also fail? Same for renaming the references/files.

@aprotyas
Copy link
Member

This makes sense as long as the Sphinx project structure is unchanged.

yes, but then would the absolute paths also fail? Same for renaming the references/files.

True, that's a challenge regardless... Anyways, LGTM!

@christophfroehlich christophfroehlich merged commit dc5cd03 into master May 14, 2024
5 checks passed
@christophfroehlich christophfroehlich deleted the rm_absolute_links branch May 14, 2024 11:56
mergify bot pushed a commit that referenced this pull request May 14, 2024
@christophfroehlich @mergify
Change links to be sphinx refs (#518)
23780df 
(cherry picked from commit dc5cd03)
mergify bot pushed a commit that referenced this pull request May 14, 2024
@christophfroehlich @mergify
Change links to be sphinx refs (#518)
9189929 
(cherry picked from commit dc5cd03)
This was referenced May 14, 2024
Merged
Merged
christophfroehlich added a commit that referenced this pull request May 14, 2024
@christophfroehlich
Change links to be sphinx refs (#518)
0104f21 
(cherry picked from commit dc5cd03)
christophfroehlich added a commit that referenced this pull request May 14, 2024
@christophfroehlich
Change links to be sphinx refs (#518)
e066089 
(cherry picked from commit dc5cd03)
christophfroehlich added a commit that referenced this pull request May 14, 2024
@mergify @christophfroehlich
Change links to be sphinx refs (#518) (#523)
a035ddf 
(cherry picked from commit dc5cd03)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request May 14, 2024
@mergify @christophfroehlich
Change links to be sphinx refs (#518) (#522)
1eee236 
(cherry picked from commit dc5cd03)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@fmauch fmauch Awaiting requested review from fmauch

@jaron-l jaron-l Awaiting requested review from jaron-l

@moriarty moriarty Awaiting requested review from moriarty

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

Assignees
No one assigned
Labels
backport-humble backport-iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @aprotyas