Remove visibility macros (backport #539) #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Remove visibility macros * Remove dead target_compile_definitions (cherry picked from commit f92cc21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consequence of ros-controls/ros2_control#1627 there is an include for HARWARE_INTERFACE_PUBLIC missing, causing the build of example_7 to fail.
As we've discussed and decided in ros-controls/ros2_controllers#1053, we wanted to remove all the visibility macros and use
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)instead. I took the chance to do so here.Fixes #538 and also resolves #73
This is an automatic backport of pull request Remove visibility macros #539 done by Mergify.