Add launch tests (backport #540) #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add test for ex1 * Add test for ex2 * Add test for ex3 * Add test for ex4 * Add missing dependency * Deactivate GUI * Add test for ex5 * Add act stuff to gitignore * Deactivate gui in tests * Reduce update rate to avoid clogging the log * Use set instead of list * Add test for ex6 * Fix xacro macros and add gui launch argument * Add test for example_7 * Add test for example_8 * Add test for example_9 * Add test for example_10 * Add test for example_11 * Add test for example_12 * Add test for example_14 * Update test for example_15 * Add test for example_15 multi_cm * Add missing dependency * Add missing dependency for ex4+ex5 * Robustify tests and reuse methos for launch_testing * Fix dependencies * Use a set to compare the joint names * Reorder controller spawners * Activate assertExitCodes tests * Deactivate failing tests for example_15 * Increase timeout for example_10 * Add backward_ros everywhere * Add error output and update includes * Revert "Activate assertExitCodes tests" This reverts commit fe28c67. * Add missing import * Update ros2_control_demo_testing/package.xml Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> * Reuse check_node_running * Try to robustify example_14 tests --------- Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> (cherry picked from commit 0ba16d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old tests only test the URDF and if the view_robot.launch.py doesn't have a python syntax error and launch_ros does not complain.
The new tests for the main launch file now also check
closes #422
Deactivated tests or other temporary measures: I'll push draft PRs after merging this to not forget that!
get_node_names_and_namespacesshows it's own node name but duplicated ros2/rclpy#1320 is fixedThis is an automatic backport of pull request #540 done by [Mergify](https://mergify.com).