Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guards for correct version of ros2_control #562

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Aug 3, 2024

We lately applied some breaking behavior changes of ros2_control to the demos (e.g., #502). The idea is now to check for the correct ros2_control version at compile-time

Starting >>> ros2_control_demo_example_1
--- stderr: ros2_control_demo_example_1                         
CMake Warning at CMakeLists.txt:20 (find_package):
  Could not find a configuration file for package "ros2_control" that is
  compatible with requested version "5.0.0".

  The following configuration files were considered but not accepted:

    /workspaces/ros2_rolling_ws/install/ros2_control/share/ros2_control/cmake/ros2_controlConfig.cmake, version: 4.13.0



CMake Error at CMakeLists.txt:23 (message):
  ros2_control version 5.0.0 or higher is required. Are you using the correct branch of the ros2_control_demos repository?

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be something like this is better right?. So, you don't have to add the extra check

example_11/CMakeLists.txt Show resolved Hide resolved
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor saikishor enabled auto-merge (squash) August 3, 2024 21:18
@saikishor saikishor disabled auto-merge August 3, 2024 21:18
@saikishor saikishor enabled auto-merge (squash) August 3, 2024 21:19
@saikishor saikishor disabled auto-merge August 3, 2024 21:19
@saikishor saikishor enabled auto-merge (squash) August 3, 2024 21:19
@saikishor saikishor disabled auto-merge August 3, 2024 21:54
@saikishor saikishor enabled auto-merge (squash) August 3, 2024 21:54
@saikishor saikishor merged commit e525cd3 into master Aug 4, 2024
9 of 13 checks passed
@saikishor saikishor deleted the compile_guards branch August 4, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants