Fix deprecation warning in paramater declaration #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `pos2` and `pos4` values from int to float as type implicitly mentioned in parameter declaration as `rclpy.Parameter.Type.DOUBLE_ARRAY` in `publisher_forward_position_controller` and `publisher_joint_trajectory_controller`. Fixes: #1239
github-actions
bot
requested review from
bmagyar,
destogl,
fmauch,
mcbed,
olivier-stasse,
progtologist and
VX792
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
(cherry picked from commit 25c1f59)
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
(cherry picked from commit 25c1f59)
This was referenced Sep 5, 2024
saikishor
pushed a commit
that referenced
this pull request
Sep 5, 2024
saikishor
pushed a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
pos2andpos4values from int to float as type implicitly mentioned in parameter declaration asrclpy.Parameter.Type.DOUBLE_ARRAYinpublisher_forward_position_controllerandpublisher_joint_trajectory_controller.Fixes: #1239 in ros2_controllers