Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] reviewer lottery and fail-fast #1047

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

christophfroehlich
Copy link
Contributor

setting

  fail-fast: false

for matrix strategy. otherwise the main or test build will be cancelled if the other one fails.

Also uses now the reviewer lottery database from ros2_control_ci

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (9f7e9e9) 47.71% compared to head (7888aed) 71.72%.
Report is 24 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1047       +/-   ##
===========================================
+ Coverage   47.71%   71.72%   +24.00%     
===========================================
  Files          41       41               
  Lines        3871     3639      -232     
  Branches     1833     1781       -52     
===========================================
+ Hits         1847     2610      +763     
+ Misses        751      709       -42     
+ Partials     1273      320      -953     
Flag Coverage Δ
unittests 71.72% <73.13%> (+24.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 68.63% <100.00%> (+20.57%) ⬆️
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (+20.00%) ⬆️
...include/joint_trajectory_controller/trajectory.hpp 73.33% <ø> (+23.33%) ⬆️
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)
...roadcaster/src/force_torque_sensor_broadcaster.cpp 82.53% <75.00%> (+21.93%) ⬆️
...ory_controller/src/joint_trajectory_controller.cpp 80.45% <87.50%> (+33.33%) ⬆️
joint_trajectory_controller/src/trajectory.cpp 89.67% <77.77%> (+22.10%) ⬆️
tricycle_controller/src/tricycle_controller.cpp 60.58% <60.60%> (+27.93%) ⬆️

... and 28 files with indirect coverage changes

@bmagyar bmagyar merged commit 1c42c8d into ros-controls:master Feb 15, 2024
16 of 17 checks passed
@christophfroehlich christophfroehlich deleted the ci_reviewer_failfast branch February 17, 2024 14:30
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Feb 19, 2024
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Bumps [ros-tooling/action-ros-ci](https://github.com/ros-tooling/action-ros-ci) from 0.3.0 to 0.3.2.
- [Release notes](https://github.com/ros-tooling/action-ros-ci/releases)
- [Commits](ros-tooling/action-ros-ci@0.3.0...0.3.2)

---
updated-dependencies:
- dependency-name: ros-tooling/action-ros-ci
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants