Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Steering controllers library] Reference interfaces are body twist (backport #1168) #1174

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 18, 2024

Fixes #1167

I'm not sure if the intention of the author was to have position input, but as it is implemented we have a body twist input on reference interfaces (velocity, not position). This PR fixes this, without any attempt to deprecate the old behavior because it was just wrong.

Tests succeed on iron distro

$ colcon test --packages-select steering_controllers_library ackermann_steering_controller bicycle_steering_controller tricycl
e_steering_controller
Starting >>> steering_controllers_library
Finished <<< steering_controllers_library [0.48s]          
Starting >>> ackermann_steering_controller
Starting >>> bicycle_steering_controller
Starting >>> tricycle_steering_controller
Finished <<< tricycle_steering_controller [7.25s]                                                                                                  
Finished <<< ackermann_steering_controller [7.28s]
Finished <<< bicycle_steering_controller [7.33s]

Summary: 4 packages finished [8.33s]
```<hr>This is an automatic backport of pull request #1168 done by [Mergify](https://mergify.com).

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.43%. Comparing base (014848c) to head (03ba099).

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1174      +/-   ##
==========================================
- Coverage   86.76%   86.43%   -0.33%     
==========================================
  Files          91       91              
  Lines        7873     7874       +1     
  Branches      688      689       +1     
==========================================
- Hits         6831     6806      -25     
- Misses        795      819      +24     
- Partials      247      249       +2     
Flag Coverage Δ
unittests 86.43% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roller/test/test_ackermann_steering_controller.cpp 100.00% <ø> (ø)
...roller/test/test_ackermann_steering_controller.hpp 84.21% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.cpp 100.00% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 80.00% <ø> (ø)
...llers_library/src/steering_controllers_library.cpp 74.16% <100.00%> (ø)
...library/test/test_steering_controllers_library.cpp 100.00% <ø> (ø)
...library/test/test_steering_controllers_library.hpp 95.52% <ø> (ø)
...troller/test/test_tricycle_steering_controller.hpp 82.35% <ø> (ø)

... and 6 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit bb02f1c into iron Jun 19, 2024
11 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/iron/pr-1168 branch June 19, 2024 20:28
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant