Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ackermann steering odometry (backport #921) #956

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 30, 2023

This is an automatic backport of pull request #921 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix Ackermann steering odometry bug issue #878

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
(cherry picked from commit d915497)
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c110c0a) 47.08% compared to head (a8e90c0) 47.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             iron     #956      +/-   ##
==========================================
+ Coverage   47.08%   47.74%   +0.65%     
==========================================
  Files          40       40              
  Lines        3655     3655              
  Branches     1728     1728              
==========================================
+ Hits         1721     1745      +24     
+ Misses        738      715      -23     
+ Partials     1196     1195       -1     
Flag Coverage Δ
unittests 47.74% <100.00%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ring_controllers_library/src/steering_odometry.cpp 62.27% <100.00%> (+13.17%) ⬆️

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit 87ef807 into iron Jan 3, 2024
10 of 13 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-921 branch January 3, 2024 19:49
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Bumps [ros-tooling/setup-ros](https://github.com/ros-tooling/setup-ros) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/ros-tooling/setup-ros/releases)
- [Commits](ros-tooling/setup-ros@0.5.0...0.6.0)

---
updated-dependencies:
- dependency-name: ros-tooling/setup-ros
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants