Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move flake8 import into test #361

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Move flake8 import into test #361

merged 1 commit into from
Mar 6, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jan 22, 2024

This will allow you to ignore the test using a label exclusion pattern without the flake8 dependency present, i.e. pytest -m 'not linter'

@cottsay
Move flake8 import into test
f8bfafa 
This will allow you to ignore the test using a label exclusion pattern
without the flake8 dependency present, i.e. `pytest -m 'not linter'`
@cottsay cottsay self-assigned this Jan 22, 2024
tfoote
tfoote approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring the import here makes sense to make it more flexible.

@cottsay cottsay merged commit 74d072f into master Mar 6, 2024
9 checks passed
@cottsay cottsay deleted the cottsay/move-flake8-import branch March 6, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crola1702 Crola1702 Crola1702 approved these changes

@tfoote tfoote tfoote approved these changes

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cottsay @tfoote @Crola1702