Skip to content

Commit

Permalink
Call dpkg-buildpackage directly instead of apt-src (#986)
Browse files Browse the repository at this point in the history
The apt-src build wrapper around dpkg-buildpackage doesn't expose the
necessary configurations to specify build profiles, meaning that we
can't disable the tests using nocheck.

I was pretty sure that this scenario was working correctly, but clearly
I was mistaken or something has changed since it was implemented.
  • Loading branch information
cottsay authored Mar 15, 2023
1 parent 1ba850b commit 89d90c7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ros_buildfarm/binarydeb_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ def build_binarydeb(rosdistro_name, package_name, sourcepkg_dir, skip_tests=Fals
cmd = ['apt-src', 'import', source, '--here', '--version', version]
subprocess.check_call(cmd, cwd=source_dir, env=env)

cmd = ['apt-src', 'build', source]
cmd = ['dpkg-buildpackage', '-b', '-us', '-uc']
if skip_tests:
cmd += ['-Pnocheck']
print("Invoking '%s' in '%s'" % (' '.join(cmd), source_dir))
try:
subprocess.check_call(cmd, cwd=source_dir, env=env)
Expand Down

0 comments on commit 89d90c7

Please sign in to comment.