Skip to content

Commit

Permalink
Mount rosdoc2 source directory read-only.
Browse files Browse the repository at this point in the history
Our deprecated out-of-tree build option has been removed which means
that we now need to host our rosdoc2 sources in a read-write location to
allow build artifacts to be generated in-tree.

Mounting read-write shouldn't matter overmuch because we delete and
re-clone rosdoc2 each time the job runs[1].

[1]: https://github.com/ros-infrastructure/ros_buildfarm/blob/f8d8219b7b7566dcccd6b95a7cb880962cdd816e/ros_buildfarm/templates/doc/rosdoc2_job.xml.em#L94
  • Loading branch information
nuclearsandwich committed Mar 16, 2024
1 parent f8d8219 commit eb45b6f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions ros_buildfarm/scripts/doc/build_rosdoc2.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ def main(argv=sys.argv[1:]):
'-m',
'pip',
'install',
'--no-warn-script-location',
'--use-deprecated=out-of-tree-build',
'--break-system-packages',
'.'],
cwd=args.rosdoc2_dir)
if pip_rc:
Expand Down
2 changes: 1 addition & 1 deletion ros_buildfarm/templates/doc/rosdoc2_job.xml.em
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ else:
' --cidfile=$WORKSPACE/docker_generating_docker/docker.cid' +
' -e=HOME=/home/buildfarm' +
' -v $WORKSPACE/ros_buildfarm:/tmp/ros_buildfarm:ro' +
' -v $WORKSPACE/rosdoc2:/tmp/rosdoc2:ro' +
' -v $WORKSPACE/rosdoc2:/tmp/rosdoc2' +
' -v $WORKSPACE/ws:/tmp/ws' +
' -v $WORKSPACE/docker_doc:/tmp/docker_doc' +
hgcache_mount_arg +
Expand Down

0 comments on commit eb45b6f

Please sign in to comment.