Add display of cpu info #1010
Merged
Add display of cpu info #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
One tiny nitpick, I think it makes sense to put cpu info before docker info rather than after but I'm willing to yield to other reviewers or a strong justification. My rationale is showing hardware info (less variable) before software info (more variable).
Other than that, no objections!
|
Moved to the front. It looks like CI is failing for all the python 2.7 builds |
I had originally catted /proc/cpuinfo but it was very verbose lscpu is in util-linux which is in [essential] so should be available on systems.
tfoote
force-pushed
the
tfoote-cpu-info
branch
2 times, most recently
from
7ff265d
to
f2373e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally catted /proc/cpuinfo but it was very verbose
lscpu is in util-linux which is in [essential] so should be available on systems.