-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not install ccache unless shared_ccache is used in binarydeb #1021
Open
j-rivero
wants to merge
5
commits into
master
Choose a base branch
from
jrivero/no_ccache_if_not_shared
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d958b79
Do not install ccache unless shared_ccache is used in binarydeb
j-rivero 64df76d
Split import one per line
j-rivero 53dee3a
Found typo in format
j-rivero 27b8f67
Fix empy syntax on endif
j-rivero 13de91c
Merge branch 'master' into jrivero/no_ccache_if_not_shared
cottsay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
import copy | ||
import sys | ||
|
||
from ros_buildfarm.argument import add_argument_append_timestamp | ||
from ros_buildfarm.argument import add_argument_append_timestamp, add_argument_install_ccache | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're doing one per line for all the others. We should do that here too. Note that will move it down to keep in alphabetical order. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
from ros_buildfarm.argument import add_argument_arch | ||
from ros_buildfarm.argument import add_argument_binarypkg_dir | ||
from ros_buildfarm.argument import \ | ||
|
@@ -55,6 +55,7 @@ def main(argv=sys.argv[1:]): | |
add_argument_append_timestamp(parser) | ||
add_argument_env_vars(parser) | ||
add_argument_skip_tests(parser) | ||
add_argument_install_ccache(parser) | ||
args = parser.parse_args(argv) | ||
|
||
data = copy.deepcopy(args.__dict__) | ||
|
@@ -69,6 +70,7 @@ def main(argv=sys.argv[1:]): | |
|
||
'skip_download_sourcepkg': args.skip_download_sourcepkg, | ||
'skip_tests': args.skip_tests, | ||
'install_ccache': args.install_ccache, | ||
|
||
'binarypkg_dir': '/tmp/binarydeb', | ||
'build_environment_variables': ['%s=%s' % key_value for key_value in args.env_vars.items()], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're doing one per line for all the others. We should do that here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64df76d