Fix error message when a package isn't available #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original behavior was to raise a KeyError with the missing package name, but this was regressed to an assert with no actionable error message by a previous change. Fixes 09a78f4
clalancette
reviewed
Mar 11, 2024
| @@ -175,6 +175,8 @@ def get_binary_package_versions(apt_cache, debian_pkg_names): | |||
| pkg = apt_cache.get(debian_pkg_name) | |||
| if not pkg: | |||
| prov = apt_cache.get_providing_packages(debian_pkg_name) | |||
| if not prov: | |||
| raise KeyError("No packages available for '%s'" % (debian_pkg_name,)) | |||
| assert len(prov) == 1 | |||
There was a problem hiding this comment.
Should we remove the assert? I guess it can still trigger if len(prov) > 1, but that isn't a situation we failed on before.
There was a problem hiding this comment.
The assert should stay. We have no logic here for how to choose which package to install when there are multiple providers of a virtual package, so the added behavior here is to support only virtual packages for which there is a single provider.
...that isn't a situation we failed on before
Before #1023, there was no difference in behavior between a completely missing package and a virtual package, so we never even got this far before.
clalancette
approved these changes
Mar 11, 2024
nuclearsandwich
pushed a commit
that referenced
this pull request
Mar 16, 2024
The original behavior was to raise a KeyError with the missing package name, but this was regressed to an assert with no actionable error message by a previous change. Fixes 09a78f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original behavior was to raise a KeyError with the missing package name, but this was regressed to an assert with no actionable error message by a previous change.
Fixes #1023