Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy rosdoc2 sources into docker image instead of bind-mounting them read-only. #1030

Closed
wants to merge 5 commits into from
Closed

Copy rosdoc2 sources into docker image instead of bind-mounting them read-only. #1030

wants to merge 5 commits into from

Commits on Mar 16, 2024

  1. Remove warning suppression and dropped deprecated option.

    @nuclearsandwich
    nuclearsandwich committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    6c398ef View commit details
    Browse the repository at this point in the history

  2. Install with --break-system-packages. 

    We don't currently distribute this as a deb and I am not in the mood to
make it a user package. I might follow up by adding arguments to skip
installation of dependencies to push those into apt.
    @nuclearsandwich
    nuclearsandwich committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    26b941b View commit details
    Browse the repository at this point in the history

  3. Copy rosdoc2 into container rather than bind-mounting it read-only. 

    Our ability to do out-of-tree builds by re-enabling a deprecated pip
feature has been removed. Normally avoiding the copy here might save us
a container cache miss but since we build the rosdoc2 images with
`--force-rm` the intermediate containers are removed and thus every
build is re-run anyway.
    @nuclearsandwich
    nuclearsandwich committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    b5bf111 View commit details
    Browse the repository at this point in the history

  4. Add doesn't consider USER directives so use --chown flag.

    @nuclearsandwich
    nuclearsandwich committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    d6a4fa7 View commit details
    Browse the repository at this point in the history

  5. Don't hard-code HOME as /home/buildfarm. 

    Whether or not keeping the ubuntu user when it exists as uid 1000 is the
way forward we shouldn't hard-code paths we can get from the
environment.
    @nuclearsandwich
    nuclearsandwich committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    2a23971 View commit details
    Browse the repository at this point in the history