Set PODMAN_USERNS=keep-id when invoking 'docker run' #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
approved these changes
Mar 22, 2024
nuclearsandwich
approved these changes
Mar 29, 2024
cottsay
force-pushed
the
cottsay/podman
branch
3 times, most recently
from
eb340ea
to
e02a819
Compare
The way Dockerfiles are structured in ros_buildfarm, we're dependent on the UID staying the same when the container is run. Setting PODMAN_USERNS=keep-id when the `docker` command is backed by Podman will in effect preserve the behavior of Docker we're relying on here. When the `docker` command is backed by Docker, this shouldn't change the behavior at all.
tfoote
approved these changes
Apr 3, 2024
Z572
pushed a commit
to revyos-ros/ros_buildfarm
that referenced
this pull request
May 15, 2024
…ure#1032) The way Dockerfiles are structured in ros_buildfarm, we're dependent on the UID staying the same when the container is run. Setting PODMAN_USERNS=keep-id when the `docker` command is backed by Podman will in effect preserve the behavior of Docker we're relying on here. When the `docker` command is backed by Docker, this shouldn't change the behavior at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way Dockerfiles are structured in ros_buildfarm, we're dependent on the UID staying the same when the container is run.
Setting PODMAN_USERNS=keep-id when the
dockercommand is backed by Podman will in effect preserve the behavior of Docker we're relying on here. When thedockercommand is backed by Docker, this shouldn't change the behavior at all.So far, this change combined with #1013 has enabled use of Podman for all
releaseanddeveljobs locally.