Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up any dangling cidfiles (Container ID files) in workspace. #1047

Merged
merged 1 commit into from
May 22, 2024

Conversation

nuclearsandwich
Copy link
Contributor

We previously built container images in a docker_containers subdirectory, but that directory and its cleanup were removed in #881 which results in the cidfile left in workspace between runs.

@nuclearsandwich
Copy link
Contributor Author

Deployed via branch to doc_rosdoc2: Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

We previously built container images in a docker_containers
subdirectory, but that directory and its cleanup were removed in #881
which results in the cidfile left in workspace between runs.
@nuclearsandwich nuclearsandwich merged commit ffc6a1c into master May 22, 2024
24 checks passed
@nuclearsandwich nuclearsandwich deleted the docker-cid-cleanup branch May 22, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants