Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fixes for RPM triggers for upload jobs #1053

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 25, 2024

It turns out that the format of the sync-to-testing job names is even more complicated than what was constructed here, so we were still adding incorrect job names there. The previous update to this function didn't regress that, but it also didn't fix it.

It turns out that there are functions to just do the formatting for us, so we should just use that.

Follow-up to #1052

Here's the diff, note that rhel_ now appears in the RHEL job names.

Skipped 'upload_main' because the config is the same (dry run)
Updating job 'upload_testing' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -26 +26 @@
    -      <upstreamProjects>Hrel_sync-packages-to-testing_8_x86_64,Hrel_sync-packages-to-testing_jammy_amd64,Hrel_sync-packages-to-testing_jammy_arm64,Irel_sync-packages-to-testing_9_x86_64,Irel_sync-packages-to-testing_jammy_amd64,Irel_sync-packages-to-testing_jammy_arm64,Jrel_sync-packages-to-testing_9_x86_64,Jrel_sync-packages-to-testing_noble_amd64,Jrel_sync-packages-to-testing_noble_arm64,Rrel_sync-packages-to-testing_9_x86_64,Rrel_sync-packages-to-testing_noble_amd64,Rrel_sync-packages-to-testing_noble_arm64,import_upstream,import_upstream_rpm</upstreamProjects>
    +      <upstreamProjects>Hrel_sync-packages-to-testing_jammy_amd64,Hrel_sync-packages-to-testing_jammy_arm64,Hrel_sync-packages-to-testing_rhel_8_x86_64,Irel_sync-packages-to-testing_jammy_amd64,Irel_sync-packages-to-testing_jammy_arm64,Irel_sync-packages-to-testing_rhel_9_x86_64,Jrel_sync-packages-to-testing_noble_amd64,Jrel_sync-packages-to-testing_noble_arm64,Jrel_sync-packages-to-testing_rhel_9_x86_64,Rrel_sync-packages-to-testing_noble_amd64,Rrel_sync-packages-to-testing_noble_arm64,Rrel_sync-packages-to-testing_rhel_9_x86_64,import_upstream,import_upstream_rpm</upstreamProjects>
    >>>

It turns out that the format of the sync-to-testing job names is even
more complicated than what was constructed here, so we were still adding
incorrect job names there. The previous update to this function didn't
regress that, but it also didn't fix it.

It turns out that there are functions to just do the formatting for us,
so we should just use that.
@cottsay cottsay added the bug label May 25, 2024
@cottsay cottsay self-assigned this May 25, 2024
@cottsay cottsay merged commit 1836bae into master Jun 3, 2024
24 checks passed
@cottsay cottsay deleted the cottsay/upload-trigger-rpm-again branch June 3, 2024 15:13
@cottsay
Copy link
Member Author

cottsay commented Jun 3, 2024

This has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants