Delete any existing UID user in Dockerfile #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ros_buildfarm/templates/snippet/add_buildfarm_user.Dockerfile.em
Outdated
Show resolved
Hide resolved
tfoote
approved these changes
Oct 14, 2024
ros_buildfarm/templates/snippet/add_buildfarm_user.Dockerfile.em
Outdated
Show resolved
Hide resolved
Co-authored-by: Tully Foote <tully.foote@gmail.com>
cottsay
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1060
As discussed in issue, delete any existing user in a Dockerfile before adding the buildfarm user. This is needed because Docker ubuntu:noble now adds an 'ubuntu' user with UID=1000, which is a common UID for users running scripts.
I only tested with gen_doc_script, but I changed it in all other occurrences.