Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse deb dependency exclusions and support nocheck #964

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 4, 2022

Previous behavior is to ignore a version-based exclusion and break if any arch or profile exclusions are present. This change parses all of those exclusions and specifically adds proper support for the 'nocheck' build profile.

Given some documentation, it should be easy to add architecture exclusion support as well.

We won't get any CI for this PR because 3.x was tagged prior to the switch to GitHub Actions. I'll need to verify the fix manually.

Cherry-picked from: #919
Fixes: #963

Previous behavior is to ignore a version-based exclusion and break if
any arch or profile exclusions are present. This change parses all of
those exclusions and specifically adds proper support for the 'nocheck'
build profile.

Given some documentation, it should be easy to add architecture
exclusion support as well.

Cherry-picked from: 485921e
@cottsay cottsay added the bug label May 4, 2022
@cottsay cottsay self-assigned this May 4, 2022
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not done the testing that is mentioned myself but as a cherry pick this looks 🅰️➕ 🙇

@cottsay cottsay merged commit 11c2ec6 into 3.x Aug 11, 2022
@cottsay cottsay deleted the cottsay/deb_dependency_parsing branch August 11, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants