Preliminary support for distro-independent CI jobs #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for CI jobs which are not associated with a ROS distribution.
There was a problem hiding this comment.
This looks like a good start. I've not done a full review yet while the merge conflicts are outstanding. I've left one comment where I had questions/concerns and I think it would be good to add some documentation updates which will help build out the intent for this change, which I think based on prior conversation is to test the independent ROS Infrastructure packages.
I also think it would be a good idea to settle on global or independent as the way to describe these CI jobs and the symbol to use for them in the code. We have independent doc jobs so why do we have global CI jobs?
nuclearsandwich
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for CI jobs which are not associated with a ROS distribution. This aligns with the distro-independent documentation jobs that are already supported by
ros_buildfarm.