Restore exec dependencies during non-test system packaging #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exec dependencies were dropped in a previous change to control the inclusion of test dependencies. The exec dependencies must be present to run tests, but because they aren't necessarily needed to build, they were dropped when the tests aren't going to run. However, the buildfarm's invalidation logic will remove downstream package which declare an exec_depend on a package, so the relationship must be maintained even though the invalidation isn't actually necessary.
|
Requires #995 to pass CI |
nuclearsandwich
approved these changes
Apr 18, 2023
Filed as #1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exec dependencies were dropped in a previous change to control the inclusion of test dependencies. The exec dependencies must be present to run tests, but because they aren't necessarily needed to build, they were dropped when the tests aren't going to run. However, the buildfarm's invalidation logic will remove downstream package which declare an exec_depend on a package, so the relationship must be maintained even though the invalidation isn't actually necessary.
Follow-up to #903