[backport Humble] use cv::DestroyAllWindows (#863) (#864)

This ports #816 to ROS 2 and prevents weird exit conditions if you already closed the window backport #863 Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
ros-perception · Jan 19, 2024 · 6d5edd8 · 6d5edd8
1 parent eda1c8c
commit 6d5edd8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/image_view/src/disparity_view_node.cpp b/image_view/src/disparity_view_node.cpp
@@ -88,7 +88,7 @@ DisparityViewNode::DisparityViewNode(const rclcpp::NodeOptions & options)
 
 DisparityViewNode::~DisparityViewNode()
 {
-  cv::destroyWindow(window_name_);
+  cv::destroyAllWindows();
 }
 
 void DisparityViewNode::imageCb(const stereo_msgs::msg::DisparityImage::SharedPtr msg)

diff --git a/image_view/src/image_view_node.cpp b/image_view/src/image_view_node.cpp
@@ -259,7 +259,7 @@ void ImageViewNode::windowThread()
     }
   }
 
-  cv::destroyWindow(window_name_);
+  cv::destroyAllWindows();
 
   if (rclcpp::ok()) {
     rclcpp::shutdown();