Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish QoS updates (backport #1019) #1024

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 19, 2024

This implements the remainder of #847:

  • Make sure publishers default to system defaults (reliable)
  • Add QoS overriding where possible (some of the image_transport / message_filters stuff doesn't really support that)
  • Use the matching heuristic for subscribers consistently

This is an automatic backport of pull request #1019 done by [Mergify](https://mergify.com).

Copy link
Author

mergify bot commented Aug 19, 2024

Cherry-pick of d272c4e has failed:

On branch mergify/bp/jazzy/pr-1019
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit d272c4e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   depth_image_proc/doc/tutorials.rst
	modified:   depth_image_proc/package.xml
	modified:   depth_image_proc/src/convert_metric.cpp
	modified:   depth_image_proc/src/crop_foremost.cpp
	modified:   depth_image_proc/src/disparity.cpp
	modified:   depth_image_proc/src/point_cloud_xyz.cpp
	modified:   depth_image_proc/src/point_cloud_xyz_radial.cpp
	modified:   depth_image_proc/src/point_cloud_xyzi.cpp
	modified:   depth_image_proc/src/point_cloud_xyzrgb.cpp
	modified:   depth_image_proc/src/point_cloud_xyzrgb_radial.cpp
	modified:   depth_image_proc/src/register.cpp
	modified:   image_pipeline/doc/tutorials.rst
	modified:   image_proc/doc/tutorials.rst
	modified:   image_proc/include/image_proc/utils.hpp
	modified:   image_proc/src/crop_decimate.cpp
	modified:   image_proc/src/crop_non_zero.cpp
	modified:   image_proc/src/debayer.cpp
	modified:   image_proc/src/rectify.cpp
	modified:   image_proc/src/resize.cpp
	modified:   image_proc/src/track_marker.cpp
	modified:   image_publisher/src/image_publisher.cpp
	modified:   image_rotate/src/image_rotate_node.cpp
	modified:   image_view/src/extract_images_node.cpp
	modified:   image_view/src/image_saver_node.cpp
	modified:   image_view/src/image_view_node.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   depth_image_proc/src/point_cloud_xyzi_radial.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Aug 19, 2024
@mergify mergify bot mentioned this pull request Aug 19, 2024
This implements the remainder of #847:

 - Make sure publishers default to system defaults (reliable)
- Add QoS overriding where possible (some of the image_transport /
message_filters stuff doesn't really support that)
 - Use the matching heuristic for subscribers consistently
@mikeferguson mikeferguson merged commit 14a21c5 into jazzy Aug 19, 2024
3 checks passed
@mikeferguson mikeferguson deleted the mergify/bp/jazzy/pr-1019 branch August 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant