Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camera_calibration] fix typo self.checkerboard_flags to self._checkerboard_flags #843

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[camera_calibration] fix typo self.checkerboard_flags to self._checkerboard_flags #843

merged 1 commit into from
Jan 17, 2024

Conversation

HiroIshida
Copy link

@HiroIshida HiroIshida commented Dec 30, 2023 •
edited
Loading

This PR fixes an obvious bug.

The attributename is _cehckerboard_flag.

image_pipeline/camera_calibration/src/camera_calibration/camera_calibrator.py

Line 131 in 9488475

self._checkerboard_flags = checkerboard_flags

So, self.checkerboard_flags is a typo

@HiroIshida HiroIshida marked this pull request as ready for review December 30, 2023 01:21
mikeferguson
mikeferguson approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually trying to maintain the ROS 1 version - but this one is so clearly correct

@mikeferguson mikeferguson merged commit 958c06b into ros-perception:noetic Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeferguson mikeferguson mikeferguson approved these changes

Assignees
No one assigned
Labels
ros1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiroIshida @mikeferguson