properly remap compressed topics #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2024
|
Although this fixes numerous bugs - we should only put this in rolling - it's going to break anybody who has manually worked around all the problems of image_transport in the past - and so we should only roll this out into Jazzy |
ahcorde
approved these changes
Jan 18, 2024
25 tasks
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
## Before: Pushing into namespace is broken, only image_raw changes (camera_info and transport topics should change): ``` ros2 run image_publisher image_publisher_node --ros-args -p filename:=test.png -r image_raw:=foo/image_raw --- ros2 topic list /camera_info /foo/image_raw /image_raw/compressed /image_raw/compressedDepth /image_raw/theora ``` ## After: Pushing into namespace now works: ``` ros2 run image_publisher image_publisher_node --ros-args -p filename:=test.png -r image_raw:=foo/image_raw --- ros2 topic list /foo/camera_info /foo/image_raw /foo/image_raw/compressed /foo/image_raw/compressedDepth /foo/image_raw/theora ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Pushing into namespace is broken, only image_raw changes (camera_info and transport topics should change):
Changing the name is also broken - only image_raw changes (transport topics should change):
After:
No remap still works:
Pushing into namespace now works:
Changing the name works correctly: