Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load image_rotate::ImageRotateNode as component #856

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

mikeferguson
Copy link
Member

This is a fixed version of #820 - targeting iron

@mikeferguson
Copy link
Member Author

There is something wrong with our config for Iron targeted PRs - looking into what that is

@mikeferguson
Copy link
Member Author

@tfoote have you ever seen this? The build log shows:

 > git rev-parse origin/iron^{commit} # timeout=10
18:47:26 FATAL: Command "git rev-parse origin/iron^{commit}" returned status code 128:
18:47:26 stdout: origin/iron^{commit}
18:47:26 
18:47:26 stderr: fatal: ambiguous argument 'origin/iron^{commit}': unknown revision or path not in the working tree.
18:47:26 Use '--' to separate paths from revisions, like this:
18:47:26 'git <command> [<revision>...] -- [<file>...]'
18:47:26 

But the "iron" branch clearly exists. I can't seem to find anything that would cause this - but it's the same on every PR we have open against the iron branch. Note: the iron branch is ~3 days old, we updated rosdistro 2 days ago to reflect the forking from rolling.

@tfoote
Copy link
Contributor

tfoote commented Jan 19, 2024

I haven't seen this before. I think that the "ambiguous" is more I think about a ref collision than a missing one. I tried clearing the workspace if there was a collision with past merges/ceckouts. There was a weird cascade of rebuilds. But maybe there was a branch in the past with the same name.

I'll try to retrigger again

@tfoote
Copy link
Contributor

tfoote commented Jan 19, 2024

@ros-pull-request-builder retest this please

@tfoote
Copy link
Contributor

tfoote commented Jan 19, 2024

That looks to have made it happy again. @mikeferguson

PS to retrigger see my phrase above it has to be exact

@mikeferguson
Copy link
Member Author

@tfoote thanks!

@mikeferguson mikeferguson merged commit 8a39ce1 into ros-perception:iron Jan 19, 2024
4 checks passed
@mikeferguson mikeferguson deleted the iron_820 branch January 19, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants