Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rgba8 and bgra8 encodings by skipping alpha channel #869

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 19, 2024

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Copy link
Member

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is only part of the changes in the ROS 1 linked PR? There were 3 other files that got this support - should we add those as well?

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@mikeferguson mikeferguson merged commit 8afb78d into rolling Jan 19, 2024
3 checks passed
@mikeferguson mikeferguson deleted the ahcorde/rolling/671 branch January 19, 2024 15:05
ahcorde added a commit that referenced this pull request Jan 19, 2024
Related with the change in ROS 1
https://github.com/ros-perception/image_pipeline/pull/671/files

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jan 19, 2024
Related with the change in ROS 1
https://github.com/ros-perception/image_pipeline/pull/671/files

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
mikeferguson pushed a commit that referenced this pull request Jan 19, 2024
…channel (#869) (#895)

backport #869

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
mikeferguson pushed a commit that referenced this pull request Jan 19, 2024
…hannel (#869) (#896)

backport #869

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants