image_view: consistent image_transport #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
commented
Jan 19, 2024
| this->declare_parameter<std::string>("transport", std::string("raw")); | ||
| std::string transport = this->get_parameter("transport").as_string(); | ||
| // TransportHints does not actually declare the parameter | ||
| this->declare_parameter<std::string>("image_transport", std::string("raw")); |
There was a problem hiding this comment.
NOTE: if we back port this - we probably need to revert the change in name of this parameter
mikeferguson
commented
Jan 19, 2024
| @@ -75,13 +75,15 @@ ExtractImagesNode::ExtractImagesNode(const rclcpp::NodeOptions & options) | |||
| auto node_base = this->get_node_base_interface(); | |||
| std::string topic = node_base->resolve_topic_or_service_name("image", false); | |||
|
|
|||
| this->declare_parameter<std::string>("transport", std::string("raw")); | |||
| // TransportHints does not actually declare the parameter | |||
| this->declare_parameter<std::string>("image_transport", "raw"); | |||
There was a problem hiding this comment.
Same here - renamed parameter for consistency with image_transport specification - I've noted both instances of this in my Jazzy: Documentation ticket so we can mention the changed parameter name
25 tasks
ahcorde
requested changes
Jan 19, 2024
mikeferguson
changed the title
ahcorde
approved these changes
Jan 19, 2024
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
All of these nodes already have the proper remapping support - but image_transport parameter support was scattered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these nodes already have the proper remapping support - but image_transport parameter support was scattered