Update extract_images_sync to add sec_per_frame parameter #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
requested changes
Jan 31, 2024
1. Set default value for sec_per_frame to 0. 2. changed time variable to last_frame_time.
Ensure delay is compared with the sec_per_frame value as a float.
mikeferguson
requested changes
Jan 31, 2024
|
I just pushed a commit that:
Tested locally and works |
mikeferguson
approved these changes
Jan 31, 2024
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
…tion#920) Added sec_per_frame parameter to allow decimation of frames being synchronized and captured. fixes ros-perception#726 --------- Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sec_per_frame parameter to allow decimation of frames being synchronized and captured.
fixes #726