Vga scale #951
Open
Vga scale #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <mtglucas1@gmail.com> Revert "Initial Merging: Setting up ImageSaverNode" This reverts commit 4534c95. DisparityNode: replace full_dp parameter with sgbm_mode (ros-perception#945) Previously, only the SGBM and HH modes were allowed add invalid_depth param (ros-perception#943) Add option to set all invalid depth pixels to a specified value, typically the maximum range. * Updates convertDepth parameter name and optimizes use of the parameter. * Updates PointCloudXYZ, PointCloudXYZI, and PointCloudXYZRGB with new invalid_depth parameter Adding scale parameter to camera calibrator Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
ahcorde
requested changes
Feb 26, 2024
| @@ -343,6 +343,7 @@ def __init__(self, boards, flags=0, fisheye_flags = 0, pattern=Patterns.Chessboa | |||
| self.pattern = pattern | |||
| self.br = cv_bridge.CvBridge() | |||
| self.camera_model = CAMERA_MODEL.PINHOLE | |||
| self.declare_parameter('vga_scale', 0) | |||
There was a problem hiding this comment.
Calibrator is not a ROS Node, this code is incorrect. You can check some failures in the CI
There was a problem hiding this comment.
If that's the case, I assume it's more practical to make the scale, a class member opposed to a function param since it's not required and would break API
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
ahcorde
requested changes
Apr 30, 2024
| @@ -343,6 +343,7 @@ def __init__(self, boards, flags=0, fisheye_flags = 0, pattern=Patterns.Chessboa | |||
| self.pattern = pattern | |||
| self.br = cv_bridge.CvBridge() | |||
| self.camera_model = CAMERA_MODEL.PINHOLE | |||
| self.vga_scale = 0 | |||
There was a problem hiding this comment.
do we need a method to set this attribute ?
There was a problem hiding this comment.
Another method has been added, just a simple way to set the scale
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #589 which asks to add a
parameterto the camera calibrator. This allows the user to preset their desired calibration scale for more precision.