[backport iron] Node namespace parameter #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
ahcorde
approved these changes
Feb 27, 2024
mikeferguson
requested changes
Feb 27, 2024
mikeferguson
approved these changes
Feb 28, 2024
| name='namespace', default_value='', | ||
| description=('namespace for all components loaded') | ||
| ) | ||
|
|
There was a problem hiding this comment.
linter seems to think that you have some spaces on this line (it shows in the individual second commit as well -although I can't actually see it highlighted here as part of the PR - which is odd)
There was a problem hiding this comment.
Yea I noticed the same thing when the flake test failed, just assumed it was a CI glitch. I've tried to retrigger by removing any sort of white space that may have come up
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport pull request #925 which solves issue #952 by adding the
namespaceparameter to theimage_proclaunch file