compressed_image_transport: image decompression as a stand-alone function. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw that the Travis build for Kinetic failed because I used a C++11 feature for generating meaningful error messages. I will fix that. |
…at is not available for ROS Kinetic.
|
Just pushed a commit that should fix the compilation issues for Kinetic, i.e. no longer using C++11 feature |
|
@dgossow The build now passes on Travis. I also checked the refactoring on my laptop by bringing up a @dgossow Could you please have a look at this pull request? |
…for using default values
…h them in publisher
image encoding as a standalone function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #49.
Basically a refactoring: It exposes image decompression as a stand-alone function in a separate lib. Additionally, it refactors the compressed subscriber to use that function.
@dgossow Could you please review this pull request?