Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename headers for humble #369

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

Conversation

smnogar
Copy link

@smnogar smnogar commented May 29, 2022

Humble has standardized a lot of standard packages on using .hpp for headers. This will break on galactic, so recommend pushing this to a new humble branch (or just make sure others are aware ros2 targets humble).

@SteveMacenski
Copy link
Member

https://build.ros2.org/job/Rpr__perception_pcl__ubuntu_jammy_amd64/1/console

The linters require the headers are also reordered, since now there are hpp files before system headers. Control+F for cpplint and it shows failures in many of the files changed due to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants