Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bag_to_pcd processing of static transforms #375

Open
wants to merge 1 commit into
base: melodic-devel
Choose a base branch
from

Conversation

peci1
Copy link

@peci1 peci1 commented Aug 17, 2022

bag_to_pcd usage of TF interface was obsolete, so it needed a ROS master running and filled TF buffer by publishing transforms via a tf::TransformPublisher. More importantly, it did not correctly handle static TFs, which resulted in inability to resolve static frames.

This PR rewrites the code to use tf2_ros::Buffer which does not require a running ROS master and it also adds correct handling of static frames (as long as they are found on topics ending with _static).

I only did not understand why rosbag info reports for my bags that /tf topic is of type tf2_msgs/TFMessage, while the code branch taken is the one for tf::tfMessage. Maybe it's some kind of automatic conversion from TF1 to TF2 that takes place here.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant