Skip to content

Commit

Permalink
Merge pull request #65 from confusedlama/fix_minus_sign
Browse files Browse the repository at this point in the history
remove unecessary minus signs
  • Loading branch information
Flova authored May 8, 2024
2 parents b63672e + 053decd commit 1e08e99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ipm_library/ipm_library/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def line_plane_intersections(
:returns: A nx3 array containing the 3d intersection points with n being the number of rays.
"""
n_dot_u = np.tensordot(plane_normal, ray_directions, axes=([0], [1]))
relative_ray_distance = -plane_normal.dot(-plane_base_point) / n_dot_u
relative_ray_distance = plane_normal.dot(plane_base_point) / n_dot_u

# we are casting a ray, intersections need to be in front of the camera
relative_ray_distance[relative_ray_distance <= 0] = np.nan
Expand Down

0 comments on commit 1e08e99

Please sign in to comment.