Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rclcpp action example] Added new action package: random_generator #336

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

Tirine
Copy link

@Tirine Tirine commented Jan 29, 2022

It's including an action interface, action client and action server, all in one.

I was going through the action server/client tutorials from the ROS2 Documentation and I started thinking about that it should be possible to do quite easily in one package, exactly like for the service/client tutorials and it's Expanding on ROS2 Interfaces.

Though I couldn't find any documentation on it, so I just went through the trial and error process of it myself, though I should share it as an example.

A suggestion would be to add a small notice of this in the tutorial as well!

Signed-off-by: Rasmus Larsson, larsson.rasmus@gmail.com

… client and action server, all in one.

Signed-off-by: Tirine <larsson.rasmus@gmail.com>
@adityapande-1995
Copy link
Contributor

@ros-pull-request-builder retest this please

@adityapande-1995
Copy link
Contributor

@ros-pull-request-builder retest this please

@Tirine
Copy link
Author

Tirine commented Mar 14, 2022

@ros-pull-request-builder retest this please

Is there something I can do to help? Unit tests or make sure I've conformed to style guides etc?

@adityapande-1995
Copy link
Contributor

@ros-pull-request-builder retest this please

Is there something I can do to help? Unit tests or make sure I've conformed to style guides etc?

We're transitioning CI to Ubuntu Jammy and that is causing some hiccups. The failures are due to some build-farm issues. I'll trigger a full CI to test this PR.

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants