Capture the environment variables in TimerAction #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Javier D'Alessandro Szymanowski <sdalessandro@fi.uba.ar>
sjdalessandro
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
launch/test/launch/actions/test_replace_environment_variables.py
Outdated
Show resolved
Hide resolved
launch/test/launch/actions/test_replace_environment_variables.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Sebastian Javier D'Alessandro Szymanowski <sdalessandro@fi.uba.ar>
Signed-off-by: Sebastian Javier D'Alessandro Szymanowski <sdalessandro@fi.uba.ar>
adityapande-1995
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for ros2/launch_ros#376
I've created a new action,
ReplaceEnvironmentVariables, which keeps a copy of the environment variables present in the system when aTimerActionis executed. The system environment variables are then temporarily replaced by that copy before the scheduled actions are performed.Feedback is welcome.