-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github templates for bug reports and features. Also links for important ROS related sites. #782
base: rolling
Are you sure you want to change the base?
Conversation
👍 |
b9044cc
to
f6469d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is good enhancement! thanks for the PR.
d6ca727
to
47a15a4
Compare
7514aa5
to
62a683c
Compare
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
62a683c
to
36b4221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I made a few small suggestions.
It's also probably best to remove the existing issue template correct?
Co-authored-by: Audrow Nash <audrow@intrinsic.ai> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Audrow Nash <audrow@intrinsic.ai> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Audrow Nash <audrow@intrinsic.ai> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestions.
@peterborkuti, should the existing template be removed in this PR? Also, make sure the DCO check passes. After these, we should be able to get this in. |
16d8d3f
to
c3162bc
Compare
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
c3162bc
to
f4f64d3
Compare
@audrow |
Hi, |
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Hi,
I checked #779 and I thought, I could help.
This is what you were thinking about?
You can try the configurations here:
https://github.com/peterborkuti/launch/issues
Here is how it looks like:
I was thinking about creating drop downs with OS and DDS versions.
Hope you like it
Péter