Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github templates for bug reports and features. Also links for important ROS related sites. #782

Open
wants to merge 11 commits into
base: rolling
Choose a base branch
from

Conversation

peterborkuti
Copy link

Hi,
I checked #779 and I thought, I could help.
This is what you were thinking about?

You can try the configurations here:
https://github.com/peterborkuti/launch/issues

Here is how it looks like:
image

image

image

I was thinking about creating drop downs with OS and DDS versions.

Hope you like it
Péter

@DLu
Copy link
Contributor

DLu commented May 24, 2024

👍

Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is good enhancement! thanks for the PR.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@peterborkuti peterborkuti force-pushed the github_templates branch 2 times, most recently from d6ca727 to 47a15a4 Compare May 27, 2024 22:07
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@peterborkuti peterborkuti force-pushed the github_templates branch 6 times, most recently from 7514aa5 to 62a683c Compare May 28, 2024 12:55
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
@audrow audrow self-assigned this Jun 6, 2024
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

I made a few small suggestions.

It's also probably best to remove the existing issue template correct?

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
peterborkuti and others added 6 commits June 11, 2024 18:23
Co-authored-by: Audrow Nash <audrow@intrinsic.ai>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Audrow Nash <audrow@intrinsic.ai>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Audrow Nash <audrow@intrinsic.ai>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Copy link
Author

@peterborkuti peterborkuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@audrow
Copy link
Member

audrow commented Jun 17, 2024

@peterborkuti, should the existing template be removed in this PR?

Also, make sure the DCO check passes. After these, we should be able to get this in.

Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
@peterborkuti
Copy link
Author

@audrow
I hope, its done. I removed the old template and fixed the DCO issues.

@peterborkuti
Copy link
Author

Hi,
Is there any issue with this version?

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Peter Borkuti <peterborkuti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants