Polish the ROS 1 -> 2 CMake instructions (backport #4767) #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Polish the ROS 1 -> 2 CMake instructions * Use section headings to CMakeLists.txt steps appear in the TOC * Use modern CMake targets instead of standard CMake variables * Use Active voice and second person perspective * Include links to real examples Signed-off-by: Shane Loretz <shane.loretz@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 9d6552c)
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11111465450/artifacts/1996938105. To view the resulting site:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CMake portion of the ROS 1 to ROS 2 guide, and fixes one bug in the C++ code
package.xmlstart with format 2 since that's different from migrating from ROS 1 to ROS 2.C++ bug fix: use
->publish(instead of.publish(I have tried out all steps of the example part of the guide to make sure they work.
This is an automatic backport of pull request #4767 done by [Mergify](https://mergify.com).