-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete RQt source installation instructions. #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11146122560/artifacts/2006424474. To view the resulting site:
|
ahcorde
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to remove this
fujitatomoya
approved these changes
Oct 2, 2024
clalancette
added
the
backport-all
backport at reviewers discretion; from rolling to all versions
label
Oct 2, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5)
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5) # Conflicts: # source/How-To-Guides/RQt-Port-Plugin-Windows.rst
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5) # Conflicts: # source/How-To-Guides/RQt-Port-Plugin-Windows.rst
This was referenced Oct 2, 2024
clalancette
added a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5) # Conflicts: # source/How-To-Guides/RQt-Port-Plugin-Windows.rst
clalancette
added a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5) # Conflicts: # source/How-To-Guides/RQt-Port-Plugin-Windows.rst
clalancette
added a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5) # Conflicts: # source/How-To-Guides/RQt-Port-Plugin-Windows.rst Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
Oct 2, 2024
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup. Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 14bdbb5) # Conflicts: # source/How-To-Guides/RQt-Port-Plugin-Windows.rst Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are no longer needed, since the RQt source installation instructions are part of the "standard" development setup.
Usually I would consider making links for these, but given how outdated these are, I'd rather just remove them completely.