Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to wait for two subscriptions (backport #4674) #4800

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2024

Since, if following the tutorial to the letter, you will currently have both turtlesim and topic echo subscribed. If you do not do this, sometimes the turtle will move, sometimes it wont - depending on which subscriber the command finds first.


This is an automatic backport of pull request #4674 done by Mergify.

* Add option to wait for tso subscriptions since, if following the tutorial to the letter, you will currently have both turtlesim and topic echo subscribed. If you do not do this, sometimes the turtle will move, sometimes it wont - depending on which subscriber the command finds first.

* wip. Requested to change the flow a bit

* As suggested, moved the continuous publishing version to be first, then go into the --once version.

* added some changes recommended by clalancette

* remove annoying blank line

* Update source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Topics/Understanding-ROS2-Topics.rst

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 9d2907e)
Copy link

github-actions bot commented Oct 2, 2024

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11148168095/artifacts/2007056667.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4800/index.html in your favorite browser

@clalancette clalancette merged commit 6723b60 into jazzy Oct 2, 2024
4 checks passed
@clalancette clalancette deleted the mergify/bp/jazzy/pr-4674 branch October 2, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants